feat(scully): use typescript for config files #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using JS, we can now use TS for config files. Scully will compile the TS down js before it loads it
|
This pr removes schematics/scully/package-lock.json. |
jorgeucano
approved these changes
May 6, 2020
|
@atao60, yes, as we are in a mono-repo, and those are out of sync by definition. |
|
@SanderElias, OK. What are your recommendation to resolve conflict with pr #531? |
atao60
pushed a commit
to atao60/scully
that referenced
this pull request
May 6, 2020
instead of using JS, we can now use TS for config files. Scully will compile the TS down js before it loads it
atao60
added a commit
to atao60/scully
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
It now expects a config TS file, and will throw if its not there.
Other information