Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type slugs as possibly non-empty #53

Merged
merged 1 commit into from
Dec 19, 2019
Merged

fix: type slugs as possibly non-empty #53

merged 1 commit into from
Dec 19, 2019

Conversation

LayZeeDK
Copy link
Contributor

The slugs property of ScullyRoute is currently typed as an array of empty strings.

This probably doesn't cause any errors right now, but unless this is intentional, I suggest we use a more appropriate type.

SanderElias
SanderElias approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@SanderElias SanderElias merged commit 4d5b46a into scullyio:master Dec 19, 2019
@LayZeeDK LayZeeDK deleted the LayZeeDK/bugfix/scully-route-interface-slugs branch December 19, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanderElias SanderElias SanderElias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LayZeeDK @SanderElias