Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scully): puppeteerRender: add validation for html with undefined #495

Merged
merged 1 commit into from
Apr 23, 2020
Merged

fix(scully): puppeteerRender: add validation for html with undefined #495

merged 1 commit into from
Apr 23, 2020

Conversation

jorgeucano
Copy link
Contributor

@jorgeucano jorgeucano commented Apr 22, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: #491

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jorgeucano
Copy link
Contributor Author

@spencerb02 This is the first fix :)

spencerb02
spencerb02 approved these changes Apr 23, 2020
View reviewed changes
Copy link

@spencerb02 spencerb02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be really helpful to ensure a good build. Thank you.

SanderElias
SanderElias approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeucano jorgeucano merged commit 407afbc into master Apr 23, 2020
@jorgeucano jorgeucano deleted the fix/491 branch April 23, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanderElias SanderElias SanderElias approved these changes

@spencerb02 spencerb02 spencerb02 approved these changes

@aaronfrost aaronfrost Awaiting requested review from aaronfrost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeucano @SanderElias @spencerb02