Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scully): attach validator correctly #423

Merged
merged 1 commit into from
Mar 24, 2020
Merged

fix(scully): attach validator correctly #423

merged 1 commit into from
Mar 24, 2020

Conversation

SanderElias
Copy link
Contributor

@SanderElias SanderElias commented Mar 24, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

validator attached on the wrong insertion point

Issue Number: N/A

What is the new behavior?

the validators are properly attached

Does this PR introduce a breaking change?

  • [] Yes
  • No

Other information

@SanderElias
Copy link
Contributor Author

@peterbsmith2 This is the validator fix for your issue

@SanderElias SanderElias merged commit e538516 into master Mar 24, 2020
@SanderElias SanderElias deleted the sander/fixValidatorNotBeingCalled branch March 24, 2020 19:11
@SanderElias SanderElias mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfrost aaronfrost aaronfrost approved these changes

@jorgeucano jorgeucano Awaiting requested review from jorgeucano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanderElias @aaronfrost