fix(schematic): v8 support in AppModule #421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using
ng add @scullyio/init
into a v8 project, the schematic checks the version to add the right dependency into the package.json file but it doesn't check it to add the right import into the AppModule file.Resulting having :
Issue Number: #419
What is the new behavior?
The schematic checks the angular version of the project for the import added into the AppModule file.
Does this PR introduce a breaking change?
Other information
The PR removes a legacy test based on #242 action