Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematic): v8 support in AppModule #421

Merged
merged 1 commit into from
Mar 26, 2020
Merged

fix(schematic): v8 support in AppModule #421

merged 1 commit into from
Mar 26, 2020

Conversation

geromegrignon
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

When using ng add @scullyio/init into a v8 project, the schematic checks the version to add the right dependency into the package.json file but it doesn't check it to add the right import into the AppModule file.
Resulting having :

// package.json
'@scullyio/ng-lib-v8'

// AppModule.ts
import { ScullyLibModule } from '@scullyio/ng-lib'

Issue Number: #419

What is the new behavior?

The schematic checks the angular version of the project for the import added into the AppModule file.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The PR removes a legacy test based on #242 action

fix v8 support in AppModule
remove legacy test based on #242 action
fix #419
@jorgeucano jorgeucano self-requested a review March 24, 2020 16:56
@jorgeucano jorgeucano merged commit 8367951 into scullyio:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants