Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scully): add support to set the number of cores during rendering, #420

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

SanderElias
Copy link
Contributor

@SanderElias SanderElias commented Mar 24, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Currently, the number of concurrent rendering threads equals node cpus().length (all threads on all cores)

Issue Number: N/A

What is the new behavior?

Have a setting in scullyconfig that allows changing this to whatever value fits the app.
Also, add a utility function to the transfer state that makes it easier to incorporate using the Scully state

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jorgeucano jorgeucano merged commit 3596179 into master Mar 24, 2020
@jorgeucano jorgeucano deleted the sander/tsStateExpansion branch March 24, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants