Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scully): add Flash Prevention Plugin #418

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Conversation

aaronfrost
Copy link
Contributor

Initial add of flash prevention plugin

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Initial add of flash prevention plugin
@aaronfrost
Copy link
Contributor Author

This sucks. The stuff is only failing as a result of our weird setup with Scully. It runs in production, as it will be released to 1800Contacts.

@jorgeucano
Copy link
Contributor

I think The merge conflict broken the import! I will check tomorrow morning

This build needed to be more tolerant of our shitty system. So I added a build script affordance for
it.
@jorgeucano jorgeucano merged commit 480e313 into master Mar 26, 2020
@jorgeucano jorgeucano deleted the flash-prevention-fix branch March 26, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants