Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ng-add to allow to be ran multiple times #35

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Fix ng-add to allow to be ran multiple times #35

merged 1 commit into from
Dec 17, 2019

Conversation

beeman
Copy link
Contributor

@beeman beeman commented Dec 17, 2019

Fixes #30

SanderElias
SanderElias approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bram!.
LGTM, as @jorgeucano is in charge of the schematics, he is going to pick this up from here.

jorgeucano
jorgeucano approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@jorgeucano jorgeucano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @beeman !!!

@jorgeucano jorgeucano merged commit 9d4f31b into scullyio:master Dec 17, 2019
@beeman beeman deleted the beeman/init-fix branch December 17, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanderElias SanderElias SanderElias approved these changes

@jorgeucano jorgeucano jorgeucano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running ng add @scullyio/init a second time should not break the app
3 participants
@beeman @SanderElias @jorgeucano