Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extrroutes): fix bug wehre extraroutes fails #224

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

SanderElias
Copy link
Contributor

When using the extraroutes option to add an empty route to render / scully errors out

closes #223

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Scully breaks down when adding an empty route ("")
Issue Number: 223

What is the new behavior?

Works as expected, and make sure the top index.html gets generated

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

When using the extraroutes option to add an empty route to render `/` scully errors out

closes #223
@SanderElias SanderElias merged commit f07ba67 into master Jan 23, 2020
@SanderElias SanderElias deleted the sander/fixExtraRoutes branch January 23, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error compiling and serving scully app
2 participants