Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scully-routes.service): fix missing return type #172

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Conversation

SanderElias
Copy link
Contributor

Put in the correct type for the return of the getCurrent function. In some cases TS inferrrence is
off otherwise

closes #171

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

typing of the getCurrent method is off

Issue Number: #171

What is the new behavior?

It returns the correct type.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Put in the correct type for the return of the getCurrent function. In some cases TS inferrrence is
off otherwise

closes #171
Copy link
Contributor

@aaronfrost aaronfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add return types to every function and public member var of this class. This will fix countless future problems.

@aaronfrost aaronfrost merged commit 925bcb4 into master Jan 10, 2020
@aaronfrost aaronfrost deleted the sander/fix171 branch January 10, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird behavior of Observable
2 participants