Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require configValidator. Just warn if absent. #64

Closed
aaronfrost opened this issue Dec 19, 2019 · 0 comments · Fixed by #70
Closed

Don't require configValidator. Just warn if absent. #64

aaronfrost opened this issue Dec 19, 2019 · 0 comments · Fixed by #70
Assignees
@SanderElias
Labels
enhancement New feature or request

Comments

@aaronfrost
Copy link
Contributor

🧩 Feature request

Don't fail without config validators. Just warn, and add a default config validator.
@aaronfrost aaronfrost added the enhancement New feature or request label Dec 19, 2019
@SanderElias SanderElias self-assigned this Dec 20, 2019
SanderElias added a commit that referenced this issue Dec 20, 2019
@SanderElias
feat(registerplugin): make configValidators optional
10bd37c 
This pr makes configvalidatios optional.

closes #64
@SanderElias SanderElias mentioned this issue Dec 20, 2019
Merged
SanderElias added a commit that referenced this issue Dec 20, 2019
@SanderElias
feat(registerplugin): make configValidators optional (#70)
83ba3f7 
This pr makes configvalidatios optional.

closes #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SanderElias SanderElias

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(registerplugin): make configValidators optional scullyio/scully
2 participants
@aaronfrost @SanderElias