Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs-Showcase] add link on images #538

Closed
geromegrignon opened this issue May 10, 2020 · 4 comments
Closed

[Docs-Showcase] add link on images #538

geromegrignon opened this issue May 10, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@geromegrignon
Copy link
Contributor

🧩 Feature request

Description

The showcase page of the official documentation might look cleaner by having the link to the website directly on the logo rather than with a separate link

Actual Documentation

scully io_docs_showcase_

Proposition

scully io_docs_showcase

Describe the solution you'd like

Use following markdown syntax

[![alt text](image link)](website link)

I can handle a PR if accepted.
@geromegrignon geromegrignon added the enhancement New feature or request label May 10, 2020
@SanderElias
Copy link
Contributor

@geromegrignon Good catch!. We are doing some refactorings now, and I will pick this up while I'm working on that.

@jorgeucano
Copy link
Contributor

@GuzmanPI Can you take a look?

@GuzmanPI
Copy link
Contributor

Yes @jorgeucano I'll take a look at it

@GuzmanPI GuzmanPI mentioned this issue May 25, 2020
Merged
10 tasks
@GuzmanPI
Copy link
Contributor

This has been addresed

SanderElias pushed a commit that referenced this issue May 26, 2020
@GuzmanPI
docs(grammar): improve grammar for the docs (#579)
a73558d 
In addition, address issue #538
@ronnysuero ronnysuero mentioned this issue Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SanderElias @GuzmanPI @jorgeucano @geromegrignon