Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error when registering plugin of the wrong type. #219

Closed
aaronfrost opened this issue Jan 22, 2020 · 0 comments · Fixed by #225
Closed

Better error when registering plugin of the wrong type. #219

aaronfrost opened this issue Jan 22, 2020 · 0 comments · Fixed by #225

Comments

@aaronfrost
Copy link
Contributor

If I called register plugin with a wrong type, we should give a better error.

The plugin type 'foo' is not a valid plugin type. Please call 'registerPlugin' with one of the following values: 'fileHandler', 'router', 'render'
SanderElias added a commit that referenced this issue Jan 23, 2020
@SanderElias
fix(registerplugin): better error on type
434804d 
When given the wrong type for a plugin, throw a proper explaination.

closes #219
@SanderElias SanderElias mentioned this issue Jan 23, 2020
Merged
10 tasks
SanderElias added a commit that referenced this issue Jan 23, 2020
@SanderElias
fix(registerplugin): better error on type (#225)
99c0253 
* fix(registerplugin): better error on type

When given the wrong type for a plugin, throw a proper explaination.

closes #219

* fix(typo): fix typo in errormessage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(registerplugin): better error on type scullyio/scully
1 participant
@aaronfrost