Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.bin/scully is published as CRLF #192

Closed
lacolaco opened this issue Jan 18, 2020 · 1 comment
Closed

.bin/scully is published as CRLF #192

lacolaco opened this issue Jan 18, 2020 · 1 comment
Labels
bug Something isn't working need more info

Comments

@lacolaco
Copy link

lacolaco commented Jan 18, 2020 •
edited
Loading

🐞 Bug report

Description

after package installed, node_modules/.bin/scully is written with CRLF. It occurs error like below

$ yarn scully
yarn run v1.17.3
$ scully
env: node\r: No such file or directory
error Command failed with exit code 127.

Similar issue: mrmlnc/svg2sprite-cli#4

🔬 Minimal Reproduction

💻Your Environment

Angular Version:


Angular CLI: 9.0.0-rc.3
Node: 10.16.0
OS: darwin x64
Angular: 9.0.0-rc.3
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Scully Version:


    "@scullyio/init": "^0.0.11",
    "@scullyio/ng-lib": "^0.0.9",
    "@scullyio/scully": "^0.0.55",

🔥 Exception or Error
@lacolaco lacolaco added the bug Something isn't working label Jan 18, 2020
@jorgeucano
Copy link
Contributor

Hey @lacolaco I'm tested in windows & mac and @SanderElias tested in linux and work in all OS...
Can you give me more information for reproduce this issue?

SanderElias added a commit that referenced this issue Jan 21, 2020
@SanderElias
fix(line-endings): conver line-endings to lf only, to prevent probl…
f76ac7c 
…ems running scully in CI

closes #192
d-koppenhagen pushed a commit to d-koppenhagen/scully that referenced this issue Jan 25, 2020
@SanderElias @d-koppenhagen
Sander/normalize line endings (scullyio#201)
c104d61 
* Saving files before refreshing line endings
* normalized files
* fix(line-endings): convert line-endings to `lf` only, to prevent problems running scully in CI

closes scullyio#192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working need more info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lacolaco @jorgeucano