feat(scully): cache the version number during rendering (#497)

scullyio · Apr 23, 2020 · edbdcc3 · edbdcc3
1 parent 2ecc216
commit edbdcc3
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/scully/renderPlugins/puppeteerRenderPlugin.ts b/scully/renderPlugins/puppeteerRenderPlugin.ts
@@ -13,13 +13,14 @@ import {createFolderFor} from '../utils';
 
 const errorredPages = new Set<string>();
 
+let version = '0.0.0';
+try {
+  const {version: pkgVersion} = jsonc.parse(readFileSync(join(__dirname, '../package.json')).toString());
+  version = pkgVersion || '0.0.0';
+} catch {}
+
 export const puppeteerRender = async (route: HandledRoute): Promise<string> => {
   const timeOutValueInSeconds = 25;
-  let version = '0.0.0';
-  try {
-    const {version: pkgVersion} = jsonc.parse(readFileSync(join(__dirname, '../package.json')).toString());
-    version = pkgVersion || '0.0.0';
-  } catch {}
   const path = scullyConfig.hostUrl
     ? `${scullyConfig.hostUrl}${route.route}`
     : `http${ssl ? 's' : ''}://${scullyConfig.hostName}:${scullyConfig.appPort}${route.route}`;