Skip to content

Commit

Permalink
fix(scully): test failing depending on timezone of the build machine (#…
Browse files Browse the repository at this point in the history
…343)

When you are in the USA and run a build, the app generates different templates during the
generation. This is because we were using the wrong field for dates, and we were not adding a
locale. Fixed that.

ISSUES CLOSED: #342
  • Loading branch information
aaronfrost authored Mar 2, 2020
1 parent 6ff4a4e commit 8305333
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ <h1>Overview of blog posts</h1>
<a *ngFor="let blog of blogs$ | async" [routerLink]="[blog.route]">
<article>
<h3>{{ blog.title || blog.route }}</h3>
<h4>{{ blog.published | date: 'shortDate' }}</h4>
<h4>{{ blog['publish date'] | date: 'shortDate':'GMT' }}</h4>
<p>{{ blog.description }}</p>
</article>
</a>
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/blog-index.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ exports[`Static: Test blog index Check clean blog index by scully 1`] = `
<link rel=\\"stylesheet\\" href=\\"styles.css\\"><script id=\\"scully-transfer-state\\"></script><style>[]{display:grid;height:100vh;grid-template-rows:60px 1fr 60px}[] > header[]{display:grid;background-color:#4169e1;color:#f5f5f5;margin:0;padding:0 10px;grid-template-columns:1fr 40px;place-items:center center}footer[] h3[], header[] h1[]{margin:0}[] > footer[]{display:grid;background-color:#4169e1;color:#f5f5f5;margin:0;padding-right:10px;justify-content:right;align-content:center}main[]{background-color:#f5f5f5;color:#040c24;padding:10px}</style><script charset=\\"utf-8\\" src=\\"blog-blog-module-es2015.js\\"></script><script charset=\\"utf-8\\" src=\\"pagenotfound-pagenotfound-module-es2015.js\\"></script><style>[]{display:grid;grid-template-columns:repeat(3,1fr);gap:10px}[] h1[]:first-child{grid-column:span 3;text-align:center}article[]{background-color:#4169e1;padding:5px;border-radius:5px;color:#f5f5f5}</style><script>window['ScullyIO']='generated';</script></head>
<body scully-version=\\"0.0.0\\">
<app-root =\\"\\" > Scully demo blog app! <small =\\"\\">rendering inside scully</small></h1><a =\\"\\" href=\\"/home\\">🏠</a></header><main =\\"\\"><router-outlet =\\"\\"></router-outlet><app-blog-list =\\"\\"><h1 =\\"\\">Overview of blog posts</h1><a =\\"\\" href=\\"/blog/2014/2/12/asdf\\"><article =\\"\\"><h3 =\\"\\">Deeply embedded</h3><h4 =\\"\\">12/31/69</h4><p =\\"\\">This is the deep folder demo page in this sample.</p></article></a><a =\\"\\" href=\\"/blog/page-1\\"><article =\\"\\"><h3 =\\"\\">My first page</h3><h4 =\\"\\"></h4><p =\\"\\">This is the first demo page in this sample.</p></article></a><a =\\"\\" href=\\"/blog/page-3\\"><article =\\"\\"><h3 =\\"\\">My third page</h3><h4 =\\"\\"></h4><p =\\"\\">At this point, I should write something different in here.</p></article></a><a =\\"\\" href=\\"/blog/page-4\\"><article =\\"\\"><h3 =\\"\\">The Rainbow Cat, A free book out of the Guttenberg library</h3><h4 =\\"\\"></h4><p =\\"\\"></p></article></a><a =\\"\\" href=\\"/blog/page-5\\"><article =\\"\\"><h3 =\\"\\">/blog/page-5</h3><h4 =\\"\\"></h4><p =\\"\\"></p></article></a><a =\\"\\" href=\\"/blog/test/testing\\"><article =\\"\\"><h3 =\\"\\">My test sub page</h3><h4 =\\"\\">12/31/69</h4><p =\\"\\">This is the second demo page in this sample.</p></article></a><!----></app-blog-list><!----></main><footer =\\"\\"><h3 =\\"\\">Made with ❤️ <strong =\\"\\">@HeroDevs</strong></h3></footer></app-root>
<app-root =\\"\\" > Scully demo blog app! <small =\\"\\">rendering inside scully</small></h1><a =\\"\\" href=\\"/home\\">🏠</a></header><main =\\"\\"><router-outlet =\\"\\"></router-outlet><app-blog-list =\\"\\"><h1 =\\"\\">Overview of blog posts</h1><a =\\"\\" href=\\"/blog/2014/2/12/asdf\\"><article =\\"\\"><h3 =\\"\\">Deeply embedded</h3><h4 =\\"\\">11/27/19</h4><p =\\"\\">This is the deep folder demo page in this sample.</p></article></a><a =\\"\\" href=\\"/blog/page-1\\"><article =\\"\\"><h3 =\\"\\">My first page</h3><h4 =\\"\\">11/26/19</h4><p =\\"\\">This is the first demo page in this sample.</p></article></a><a =\\"\\" href=\\"/blog/page-3\\"><article =\\"\\"><h3 =\\"\\">My third page</h3><h4 =\\"\\">11/28/19</h4><p =\\"\\">At this point, I should write something different in here.</p></article></a><a =\\"\\" href=\\"/blog/page-4\\"><article =\\"\\"><h3 =\\"\\">The Rainbow Cat, A free book out of the Guttenberg library</h3><h4 =\\"\\">12/16/19</h4><p =\\"\\"></p></article></a><a =\\"\\" href=\\"/blog/page-5\\"><article =\\"\\"><h3 =\\"\\">/blog/page-5</h3><h4 =\\"\\"></h4><p =\\"\\"></p></article></a><a =\\"\\" href=\\"/blog/test/testing\\"><article =\\"\\"><h3 =\\"\\">My test sub page</h3><h4 =\\"\\">11/27/19</h4><p =\\"\\">This is the second demo page in this sample.</p></article></a><!----></app-blog-list><!----></main><footer =\\"\\"><h3 =\\"\\">Made with ❤️ <strong =\\"\\">@HeroDevs</strong></h3></footer></app-root>
<script src=\\"runtime-es2015.js\\" type=\\"module\\"></script><script src=\\"runtime-es5.js\\" nomodule=\\"\\" defer=\\"\\"></script><script src=\\"polyfills-es5.js\\" nomodule=\\"\\" defer=\\"\\"></script><script src=\\"polyfills-es2015.js\\" type=\\"module\\"></script><script src=\\"main-es2015.js\\" type=\\"module\\"></script><script src=\\"main-es5.js\\" nomodule=\\"\\" defer=\\"\\"></script>
</body></html>"
Expand Down

0 comments on commit 8305333

Please sign in to comment.