Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop --manhole support for now. #863

Merged
merged 1 commit into from
Feb 1, 2019
Merged

drop --manhole support for now. #863

merged 1 commit into from
Feb 1, 2019

Conversation

kmike
Copy link
Member

@kmike kmike commented Feb 1, 2019

It was never tested or documented properly, and stopped working after Twisted update.

It was never tested or documented properly,
and stopped working after Twisted update.
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #863 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage    87.5%   87.65%   +0.14%     
==========================================
  Files          41       41              
  Lines        5732     5717      -15     
  Branches      792      791       -1     
==========================================
- Hits         5016     5011       -5     
+ Misses        534      525       -9     
+ Partials      182      181       -1
Impacted Files Coverage Δ
splash/server.py 74.59% <ø> (+3.52%) ⬆️
splash/defaults.py 100% <ø> (ø) ⬆️

@kmike kmike merged commit 47f7074 into master Feb 1, 2019
@kmike kmike deleted the drop-manhole branch February 1, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant