fix mac installation issues #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add pyOpenSSL to requirements; * use psutil for get_num_fds; * handle cases when RLIMIT_NOFILE can't be increased to hard maximum
|
Thanks for the contribution @kmike. I was reluctant at first to add external dependencies, so I went with reading /proc/ instead of adding psutil dependency, but I'm in favor of adding dependencies if it means more portability, and as long as it's done in a controlled way. |
|
I would also move pyOpenSSL to the test requirements section in requirements.txt |
…ired Debian packages
It used to work on OS X 10.7, but in 10.8 splash requires more time to start and this makes all tests fail.
…; replace PIL with Pillow
|
@pablohoffman could you please review this? I fixed pyOpenSSL as you suggested; also, there was an another hair-pulling OS X installation issue that is sort-of fixed now (at least tests work reliably for me). |
pablohoffman
added a commit
that referenced
this pull request
Aug 14, 2013
fix mac installation issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds psutil to requirements. What do you think about using it instead of stdlib's resources module for other things as well?