Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] 'images' parameter for turning images ON/OFF #105

Merged
merged 1 commit into from
Jul 22, 2014

Conversation

kmike
Copy link
Member

@kmike kmike commented Jul 22, 2014

Also, fixes the git image in tests (it was not 100% black).
@kmike kmike changed the title 'images' parameter for turning images ON/OFF [MRG] 'images' parameter for turning images ON/OFF Jul 22, 2014
@redapple
Copy link
Contributor

+1

@pablohoffman
Copy link
Contributor

Nice tests :)

I noticed many messages like these in travis tests:

exceptions.RuntimeError: Request.finish called on a request after its connection was lost; use Request.notifyFinish to keep track of this.

But I guess these aren't necessarily caused by these changes, right?

@kmike
Copy link
Member Author

kmike commented Jul 22, 2014

These RuntimeErrors are weird, see #87

@pablohoffman
Copy link
Contributor

Thanks, I missed that ticket.

pablohoffman added a commit that referenced this pull request Jul 22, 2014
[MRG] 'images' parameter for turning images ON/OFF
@pablohoffman pablohoffman merged commit 5fbb1b7 into scrapinghub:master Jul 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants