Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use ports from ephemeral ports range instead of hardcoded ports #30

Closed
kmike opened this issue Aug 27, 2013 · 0 comments
Closed

Comments

@kmike
Copy link
Member

kmike commented Aug 27, 2013

Currently tests can fail or behave incorrectly when splash instance is running. It could be better to use temporary ports for splash server, mock server and proxy server.

>>> import socket
>>> s = socket.socket()
>>> s.bind(("", 0))
>>> s.getsockname()
('0.0.0.0', 54485)

For proxy server it may require more code because its port is in config that is stored in VCS; it may be OK not to fix this issue for proxy server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant