Add failing test for package with invalid specifier in dependencies

sbidoul · May 4, 2024 · 587854a · 587854a
1 parent b63e279
commit 587854a
Show file tree

Hide file tree

Showing 6 changed files with 35 additions and 0 deletions.
diff --git a/tests/data/indexes/require-invalid-version/invalid-version/index.html b/tests/data/indexes/require-invalid-version/invalid-version/index.html
@@ -0,0 +1,6 @@
+<!DOCTYPE html>
+<html>
+  <body>
+    <a href="../../../packages/invalid_version-2010i-py3-none-any.whl">invalid_version-2010i-py3-none-any.whl</a>
+  </body>
+</html>
diff --git a/tests/data/indexes/require-invalid-version/require-invalid-version/index.html b/tests/data/indexes/require-invalid-version/require-invalid-version/index.html
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<html>
+  <body>
+    <a href="../../../packages/require_invalid_version-0.1-py3-none-any.whl">require_invalid_version-0.1-py3-none-any.whl</a>
+    <a href="../../../packages/require_invalid_version-1.0-py3-none-any.whl">require_invalid_version-1.0-py3-none-any.whl</a>
+  </body>
+</html>
diff --git a/tests/data/packages/README.txt b/tests/data/packages/README.txt
@@ -112,3 +112,11 @@ The invalid-version package with a legacy version.
 invalid_version-1.0-py3-none-any.whl
 ------------------------------------
 A valid variant of the invalid-version package.
+
+require_invalid_version-0.1-py3-none-any.whl
+--------------------------------------------
+A valid variant of the require-invalid-version package.
+
+require_invalid_version-1.0-py3-none-any.whl
+--------------------------------------------
+This package has an invalid version specifier in its requirements.
diff --git a/tests/data/packages/require_invalid_version-0.1-py3-none-any.whl b/tests/data/packages/require_invalid_version-0.1-py3-none-any.whl
diff --git a/tests/data/packages/require_invalid_version-1.0-py3-none-any.whl b/tests/data/packages/require_invalid_version-1.0-py3-none-any.whl
diff --git a/tests/functional/test_invalid_versions_and_specifiers.py b/tests/functional/test_invalid_versions_and_specifiers.py
@@ -13,3 +13,17 @@ def test_install_from_index_with_invalid_version(
         "install", "--dry-run", "--index-url", index_url, "invalid-version"
     )
     assert "Would install invalid-version-1.0" in result.stdout
+
+
+def test_install_from_index_with_invalid_specifier(
+    script: PipTestEnvironment, data: TestData
+) -> None:
+    """
+    Test that pip does not crash when installing a package with an invalid
+    version specifier in its dependencies.
+    """
+    index_url = data.index_url("require-invalid-version")
+    result = script.pip(
+        "install", "--dry-run", "--index-url", index_url, "require-invalid-version"
+    )
+    assert "Would install require-invalid-version-0.1" in result.stdout