Adding quiet zone header to control the quiet zone #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks 👍. I'll review soon. |
|
Works perfectly. |
sayanarijit
added a commit
that referenced
this pull request
Sep 24, 2021
sayanarijit
added a commit
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sayanarijit
This adds a quiet zone header. The quiet zone is a padding that is added to the QR code to help avoid the scanner picking up it's surroundings.
Ressource: https://delivr.com/faq/1455/whats-with-the-white-border-around-the-qr-code
I have added the quiet zone function call to all formats. The default behaviour is false. My change will not interfere with the default behaviour that this library has. It will however give me the option to disable the quiet zone.
Warning: I do not usually develop in Rust.
Which means I probably hasn't done it the right way. You know the gist though. So maybe you can help ease out the kinks?