Missing getters on Savon::Response soap_fault/soap_error #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you're right. seems like those slipped through the major version refactorings. |
pigoz
added a commit
to pigoz/savon
that referenced
this pull request
May 14, 2013
These two methods were removed in the big refactoring for the major release. Add them back since they are the only API to access the errors when the client is configured with `:raise_errors => false`. Fixes savonrb#450
|
Here it is. Please let me know if I have to change something! :) Cheers |
|
that's perfect! can you update the changelog? |
These two methods were removed in the big refactoring for the major release. Add them back since they are the only API to access the errors when the client is configured with `:raise_errors => false`. Fixes savonrb#450
|
Done! Listed it as |
rubiii
added a commit
that referenced
this pull request
May 14, 2013
Missing getters on Savon::Response soap_fault/soap_error
|
yeah, could be both :) thanks @pigoz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Savon::Responseis missing getterssoap_faultandsoap_errorto access these exceptions when using:raise_errors => false,.Please let me know if I overlooked something. If not, I will prepare a pull request if you are busy.