Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL version with tests #64

Merged
merged 4 commits into from
Oct 12, 2012
Merged

SSL version with tests #64

merged 4 commits into from
Oct 12, 2012

Conversation

RichGuk
Copy link

@RichGuk RichGuk commented Oct 12, 2012

I've written tests for pull request #60, which was a follow up to pull request #50. INCEPTION.

@robwilliams
Copy link

+1

@rubiii
Copy link
Contributor

rubiii commented Oct 12, 2012

awesome. thank you very much @RichGuk.
there is one commented out spec which can probably be removed, right?

@RichGuk
Copy link
Author

RichGuk commented Oct 12, 2012

Ops. Ah yeah you can safely remove that; I realised that curb required different specs from the others.

rubiii added a commit that referenced this pull request Oct 12, 2012
@rubiii rubiii merged commit ca161b5 into savonrb:master Oct 12, 2012
This was referenced Oct 12, 2012
@rubiii
Copy link
Contributor

rubiii commented Oct 12, 2012

merged support for specifying an ssl version into master and updated the readme.
please give it a try before it's going to be released.

@RichGuk
Copy link
Author

RichGuk commented Oct 15, 2012

Excellent, thank you. Have been testing the SSL stuff and it works perfectly (at least with net/http). A release soon would be awesome, currently waiting on a project release that uses Savon but needs this SSL fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants