Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ssl so that cert and cert_key can be manually set #49

Closed
wants to merge 1 commit into from

Conversation

mwagg
Copy link
Contributor

@mwagg mwagg commented Mar 9, 2012

Hi,

I'm getting my ssl key and certificate from an instance of OpenSSL::PKCS12 so I'm manually setting cert and cert_key on HTTPI::Auth::SSL. The code for the read side of these properties meant that unless cert_file is also set, they will always return nil. So when HTTPI::Auth::SSL.present? is called it returns false and ssl is not used for my connection.

I've fixed the readers and added a couple of tests to prove it works.

@tjh
Copy link

tjh commented Apr 24, 2012

👍

This fix is correct and the tests are solid.

@rubiii
Copy link
Contributor

rubiii commented Apr 25, 2012

failed to reference the commit, but it's merged. thanks for this and thanks for testing :)

@rubiii rubiii closed this Apr 25, 2012
@mwagg
Copy link
Contributor Author

mwagg commented Apr 25, 2012

Sorry if I'm being dumb here, but what do you mean by failed to reference the commit?

@rubiii
Copy link
Contributor

rubiii commented Apr 26, 2012

github automatically references commits in pull requests/issue when your commit message
includes "closes #49" for example. no big deal :)

@mwagg
Copy link
Contributor Author

mwagg commented Apr 26, 2012

Ah well there was no issue for this. I had just fixed it in my fork which I am using in production and then sent the pull request with the commit. I will add an issue first if I do any more.

@rubiii
Copy link
Contributor

rubiii commented Apr 26, 2012

actually, pull requests are issues. if you look at the issues you will see some with "code attached" which link to pull requests.

@rubiii
Copy link
Contributor

rubiii commented Apr 26, 2012

released as v0.9.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants