Deprecation warning for ruby 2.5.0 fixed #189

webhoernchen · 2018-01-02T08:40:24Z

httpi/auth/ssl.rb:13: warning: constant OpenSSL::SSL::SSLContext::METHODS deprecated

* httpi/auth/ssl.rb:13: warning: constant OpenSSL::SSL::SSLContext::METHODS deprecated

espen · 2018-01-02T10:33:15Z

Looks good but should probably add 2.5.0 to .travis.yml to ensure test coverage.

tycooon · 2018-01-02T10:39:38Z

lib/httpi/auth/ssl.rb

+      SSL_VERSIONS = if ssl_context.const_defined? :METHODS_MAP
+        ssl_context.const_get(:METHODS_MAP).keys
+      else
+        ssl_context::METHODS.reject { |method| method.match(/server|client/) }


Why are you using const_get in one case and :: in other?

because METHODS_MAP is a private constant.

Because METHODS_MAP is marked as private
Look at: https://github.com/ruby/ruby/blob/trunk/ext/openssl/lib/openssl/ssl.rb#L222

Well, it sucks that we are using private constants from other libs :(

Well, it sucks that we are using private constants from other libs :(

@tycooon I agree with you.

Someone suggests a better approach?

These values change by different OpenSSL::SSL::SSLContext? We can't set this values on SSL_VERSIONS directly?

I only see either fetching it from the OpenSSL lib as @webhoernchen is doing it or defining it directly SSL_VERSIONS = [:TLSv1_2, :TLSv1_1, :TLSv1, :SSLv3, :SSLv23] but having to update it manually if anything changes.

@webhoernchen what do you think? I see no problem with SSL_VERSIONS = [:TLSv1_2, :TLSv1_1, :TLSv1, :SSLv3, :SSLv23] approach.

bakku · 2018-01-11T10:55:08Z

I think it makes sense to fix the deprecation warnings in the specs as well

https://github.com/savonrb/httpi/blob/master/spec/httpi/auth/ssl_spec.rb#L6
https://github.com/savonrb/httpi/blob/master/spec/httpi/adapter/curb_spec.rb#L260

Is it possible to get a release after merging? We have a lot of cronjobs executing rake tasks and I get emails for every cronjob because of the deprecation warning 😅

coveralls · 2018-01-11T12:18:34Z

Coverage increased (+0.03%) to 97.156% when pulling 3fedfb6 on webhoernchen:master into 7bc8ed8 on savonrb:master.

rogerleite · 2018-01-11T12:45:32Z

lib/httpi/auth/ssl.rb

+      SSL_VERSIONS = if ssl_context.const_defined? :METHODS_MAP
+        ssl_context.const_get(:METHODS_MAP).keys
+      else
+        ssl_context::METHODS.reject { |method| method.match(/server|client/) }


Well, it sucks that we are using private constants from other libs :(

@tycooon I agree with you.

Someone suggests a better approach?

These values change by different OpenSSL::SSL::SSLContext? We can't set this values on SSL_VERSIONS directly?

rogerleite · 2018-01-11T12:47:55Z

Is it possible to get a release after merging?

@bakku for sure! 👍
I need to check what is on master. 🤔

rogerleite · 2018-01-11T12:51:34Z

Travis is failing with jruby. https://travis-ci.org/savonrb/httpi/jobs/327656334

Seems some problem on install ...

$ rvm use jruby --install --binary --fuzzy
curl: (22) The requested URL returned error: 404 Not Found
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Required jruby-9.1.15.0200 is not installed - installing.
curl: (22) The requested URL returned error: 404 Not Found
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Searching for binary rubies, this might take some time.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Unknown ruby string (do not know how to handle): jruby-9.1.15.0200.
Requested binary installation but no rubies are available to download, consider skipping --binary flag.
Gemset '' does not exist, 'rvm jruby-9.1.15.0200 do rvm gemset create ' first, or append '--create'.
The command "rvm use jruby --install --binary --fuzzy" failed and exited with 2 during .
Your build has been stopped.

Optional quest: should be good to check if tests are ok locally with jruby.

rogerleite · 2018-01-11T13:00:05Z

@bakku next version should enter:

fix bug with rubyntlm v0.6.0 #171 fix bug with rubyntlm v0.6.0
Fix excon and http adapters #181 Fix excon and http adapters
feat: Logging ssl information of a request #183 feat: Logging ssl information of a request
only require ntlm if ntlm auth was requested. #187 only require ntlm if ntlm auth was requested

* ssl versions improved

* jruby fixed

* gemset fixed

coveralls · 2018-01-11T14:44:28Z

Coverage increased (+0.03%) to 97.156% when pulling cb2711e on webhoernchen:master into 7bc8ed8 on savonrb:master.

coveralls · 2018-01-11T14:44:28Z

Coverage increased (+0.03%) to 97.156% when pulling cb2711e on webhoernchen:master into 7bc8ed8 on savonrb:master.

coveralls · 2018-01-11T14:44:28Z

Coverage increased (+0.03%) to 97.156% when pulling cb2711e on webhoernchen:master into 7bc8ed8 on savonrb:master.

coveralls · 2018-01-11T14:51:37Z

Coverage increased (+0.03%) to 97.156% when pulling 8513213 on webhoernchen:master into 7bc8ed8 on savonrb:master.

lleger · 2018-02-11T22:40:20Z

Is this likely to get merged/released soon? Would like to clean the deprecation notice from our logs 😄

pcai · 2018-02-13T20:54:53Z

@rogerleite thanks for reviewing, does this look good now? I have permissions to merge, and can make a new release, if you'd like a hand.

rogerleite · 2018-02-14T14:32:22Z

@pcai thanks for the help. Feel free to merge and make a new release, don't forget to update changelog and bump version like this commit 7a81287

Wardrop · 2018-02-14T22:19:11Z

The guy who monitors a shared IT mailbox here at work will appreciate the reduction in Cron Daemon emails. Eagerly awaiting this release...

bakku · 2018-04-09T14:16:46Z

hi guys, any update on when we will see a release? Additionally the savon gem should probably be updated since it uses the httpi gem and therefore shows the deprecation message aswell

rogerleite · 2018-04-09T14:41:57Z

Hi @bakku, this fix is already released on version https://github.com/savonrb/httpi/releases/tag/v2.4.3

Savon needs to change add_dependency "httpi", "~> 2.3" to add_dependency "httpi", "~> 2.4"

bakku · 2018-04-09T14:45:49Z

You're right, I'm sorry. I somehow thought that the mentioned release was before this pull request. Thanks @rogerleite

* deprecation warning for ruby 2.5.0 fixed

a043743

* httpi/auth/ssl.rb:13: warning: constant OpenSSL::SSL::SSLContext::METHODS deprecated

webhoernchen mentioned this pull request Jan 2, 2018

Deprecation warning in ruby 2.5 #188

Closed

* ruby 2.5.0 to travis added

8f2b1bf

tycooon reviewed Jan 2, 2018

View reviewed changes

* Deprecation warnings in specs fixed

3fedfb6

savonrb deleted a comment from coveralls Jan 11, 2018

rogerleite requested changes Jan 11, 2018

View reviewed changes

* specs

88aefd7

* ssl versions improved

savonrb deleted a comment from coveralls Jan 11, 2018

webhoernchen added 3 commits January 11, 2018 15:21

* travis

ad484cb

* jruby fixed

* travis

cb2711e

* jruby fixed

* travis

8513213

* gemset fixed

pcai approved these changes Feb 13, 2018

View reviewed changes

rogerleite approved these changes Feb 14, 2018

View reviewed changes

savonrb deleted a comment from coveralls Feb 15, 2018

rogerleite merged commit 0358921 into savonrb:master Feb 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecation warning for ruby 2.5.0 fixed #189

Deprecation warning for ruby 2.5.0 fixed #189

webhoernchen commented Jan 2, 2018

espen commented Jan 2, 2018

tycooon Jan 2, 2018

espen Jan 2, 2018

webhoernchen Jan 2, 2018

tycooon Jan 2, 2018

rogerleite Jan 11, 2018

bakku Jan 11, 2018

rogerleite Jan 11, 2018

bakku commented Jan 11, 2018

coveralls commented Jan 11, 2018 •

edited

Loading

rogerleite Jan 11, 2018

rogerleite commented Jan 11, 2018

rogerleite commented Jan 11, 2018

rogerleite commented Jan 11, 2018 •

edited

Loading

coveralls commented Jan 11, 2018

coveralls commented Jan 11, 2018

coveralls commented Jan 11, 2018 •

edited

Loading

coveralls commented Jan 11, 2018 •

edited

Loading

lleger commented Feb 11, 2018

pcai commented Feb 13, 2018

rogerleite commented Feb 14, 2018

Wardrop commented Feb 14, 2018

bakku commented Apr 9, 2018 •

edited

Loading

rogerleite commented Apr 9, 2018

bakku commented Apr 9, 2018

Deprecation warning for ruby 2.5.0 fixed #189

Deprecation warning for ruby 2.5.0 fixed #189

Conversation

webhoernchen commented Jan 2, 2018

espen commented Jan 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bakku commented Jan 11, 2018

coveralls commented Jan 11, 2018 • edited Loading

Choose a reason for hiding this comment

rogerleite commented Jan 11, 2018

rogerleite commented Jan 11, 2018

rogerleite commented Jan 11, 2018 • edited Loading

coveralls commented Jan 11, 2018

coveralls commented Jan 11, 2018

coveralls commented Jan 11, 2018 • edited Loading

coveralls commented Jan 11, 2018 • edited Loading

lleger commented Feb 11, 2018

pcai commented Feb 13, 2018

rogerleite commented Feb 14, 2018

Wardrop commented Feb 14, 2018

bakku commented Apr 9, 2018 • edited Loading

rogerleite commented Apr 9, 2018

bakku commented Apr 9, 2018

coveralls commented Jan 11, 2018 •

edited

Loading

rogerleite commented Jan 11, 2018 •

edited

Loading

coveralls commented Jan 11, 2018 •

edited

Loading

coveralls commented Jan 11, 2018 •

edited

Loading

bakku commented Apr 9, 2018 •

edited

Loading