Pass option :ssl_version to Excon adapter #131
Conversation
|
I'm unfamiliar with the matter of correcting old versions of gems, but would it be possible to patch version 2.1 of HTTPI? I'm working on an application that uses Savon version 2.3.3, which has a dependency of httpi (~> 2.1.0), so I believe my problem would be solved if a version 2.1.1 were released with this change in effect. |
|
Awesome, that was a really fast turnaround for a pull request :) I think it's totally fine to not test this behavior. Generally I think it's a great idea to have specs that cover basically any feature, but since this is just setting some user-provided value in a really simple manner.... it doesn't seem highly valuable to write a spec for this. You are absolutely correct about how Savon's dependency on HTTPI works. Wanting to backport this to HTTPI v2.1.0 ... makes it a bit more challenging since HTTPI is currently at v2.2.6. I think that Savon was too conservative in pinning versions of gems we control back when Savon v2.3 was released, which is how we got into this mess. Would it be hard for you to upgrade to the latest stable version of Savon (v2.7.2) ? There shouldn't be any breaking changes between v2.3 and v2.7, just new features. |
Pass option :ssl_version to Excon adapter
|
Thanks. I updated both gems, and it looks like smooth sailing. |
|
Shouldn't this be outside |
|
@sshaw that seems correct. Would you mind submitting a PR for that? |
|
Sure, give me a day or so... |
|
Or 10... |
Solves the issue discussed at #130