Check rubyntlm version in a 0.4.0+ compatible way #111
Conversation
Check rubyntlm version in a 0.4.0+ compatible way
|
Thanks and sorry for the inconvenience! 👍 |
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| begin | |||
| require 'net/ntlm' | |||
| require 'net/ntlm/version' unless Net::NTLM.const_defined?(:VERSION) | |||
There was a problem hiding this comment.
This seems really weird to me. Is there a reason why the rubyntlm gem doesn't require its own version file itself when you require 'net/ntlm'? Seems very odd that anyone using ntlm would need to require that themselves.
Also, is there a reason to guard against doing this when the constant is already defined?
Sorry for all of the questions, I'm just curious -- I don't normally see a lot of ruby in this style.
There was a problem hiding this comment.
I'm not sure why rubyntlm v0.4.0 doesn't require its own version constant. It was moved there pretty recently and is required explicitly by the gemspec.
The guard against the constant already defined is to make sure this also works with rubyntlm v0.3.x, which defines VERSION in net/ntlm and does not have a net/ntlm/version file, so this require would fail without the guard in 0.3.x.
I don't know if I like this style either, but since it was broken in 0.4.0 this was a simple solution to work with both versions.
There was a problem hiding this comment.
Oh well that's really annoying. Thanks for the quick response @carlzulauf. Looks like this is the best choice for compatibility between v0.3 and v0.4.
Fixes errors caused by using
rubyntlmv0.4.0. Continues to work with v0.3.2+.