lib: do not catch user errors

The API caught errors from inside of the users passed through callback. This never caused any issues, since this API is only used internally. Otherwise it would have potentially hidden bugs in user code. Refs: nodejs#31133 PR-URL: nodejs#31159 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
santigimeno · Jan 4, 2020 · 904a81d · 904a81d
1 parent 36c212e
commit 904a81d
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/lib/internal/util/inspector.js b/lib/internal/util/inspector.js
@@ -10,15 +10,11 @@ function sendInspectorCommand(cb, onError) {
   if (!hasInspector) return onError();
   const inspector = require('inspector');
   if (session === undefined) session = new inspector.Session();
+  session.connect();
   try {
-    session.connect();
-    try {
-      return cb(session);
-    } finally {
-      session.disconnect();
-    }
-  } catch {
-    return onError();
+    return cb(session);
+  } finally {
+    session.disconnect();
   }
 }