Skip to content

Commit

Permalink
test: use ShellTestEnvironment in WPT
Browse files Browse the repository at this point in the history
So we no longer need to hack the global.location and pretend
that we are in a worker anymore.

PR-URL: nodejs#27822
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
  • Loading branch information
joyeecheung committed May 24, 2019
1 parent 2e77735 commit 0927559
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions test/common/wpt.js
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,6 @@ class WPTRunner {
fetch(file) {
return resource.fetch(file);
},
location: {},
GLOBAL: {
isWindow() { return false; }
},
Expand Down Expand Up @@ -375,8 +374,6 @@ class WPTRunner {
// TODO(joyeecheung): we are not a window - work with the upstream to
// add a new scope for us.

const { Worker } = require('worker_threads');
sandbox.DedicatedWorker = Worker; // Pretend we are a Worker
return context;
}

Expand Down

0 comments on commit 0927559

Please sign in to comment.