Gradual Dutch Auction #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Influence/Math64x61 for fixed point math - Here we use ERC721 but ERC20 could also be used
- Need to fix the refund snippet - Best way to batch mint tokens for ERC721 ?
- TODO : fix refund
- TODO: warp 10 blocks ahead in time for the tests to pass
rootulp
reviewed
Apr 19, 2022
Co-authored-by: Rootul Patel <[email protected]>
Co-authored-by: Rootul Patel <[email protected]>
|
thanks a ton to both of you for your work on this & reviewing! i've done a read through and lgtm :) will make a second pass at refining this (and a couple of the things commented out in the impl) when i get the time, but for now it'll be great to have this in for demonstration purposes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm currently implementing the Gradual Dutch Auction system on Starknet.
Please refer to this paper for more info : Paradigm Research
Making this PR but for now there is only a base implementation of the Discrete GDA.
Continous GDA will come right after.
For fixed point math, I've used cairo-math-64x61 but please let me know if you think there is a more suited one which I don't think so tho.
There are still some tweaks to make to the implementation :