SAK-42643 - Switching from fonticonpicker to fontawesome-iconpicker f… #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated this to look like the below in the code. I think this is fine, just will need to check the other tools that use this and make sure they're wrapped correctly.
|
…or keyboard accessibility and updates
…han having to hardcode it
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
basiclti/basiclti-common/src/java/org/sakaiproject/util/foorm/Foorm.java
Show resolved
Hide resolved
|
Okay this looks good. There's one more issue where if you are navigating with the keyboard and get to the icon picker, after you select an icon the focus goes to a random place on the page rather than to the next element. I'm having to call this to get the focus into the input Maybe it will have to focus back on the actual input again? Or the one after? Will have to look at that but maybe some other ideas? |
mpellicer
approved these changes
Mar 23, 2020
|
Complexity increasing per file
==============================
- library/src/webapp/js/headscripts.js 1
See the complete overview on Codacy |
ern
pushed a commit
that referenced
this pull request
Apr 20, 2020
#8027) * SAK-42643 - Switching from fonticonpicker to fontawesome-iconpicker for keyboard accessibility and updates * More code to create a better looking input field dynamically rather than having to hardcode it * Some code formatting and fixing up layout in LTI * Update pom.xml Co-authored-by: Miguel Pellicer <[email protected]> (cherry picked from commit c041445)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or keyboard accessibility and updates
I didn't see any useful updates to the previous picker and it was not keyboard accessible.
This is currently what the new one looks like
The old plugin when called turned a input text field into a field that looked like this
That seems like it's going to take a little more work with this plugin if we want to achieve that but adding our own custom callbacks. Not sure how important it is to be accessible verses working and looking like it did before.
I tried to get it to look like the "inside dropdowns" view of https://jonespm.github.io/fontawesome-iconpicker/ but seemed like it would require changing all of the current input's over to a hidden, adding a button AND modifying the callback to update the hidden value. Whenever I just had it a button with the value updated there wasn't anything posted. . .
Happy for feedback or someone else to commit on top of this. I might go back to experimenting with the button again.