Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-43381: admin workspace > announcements > fix cache refresh #7979

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

bjones86
Copy link
Member

@bjones86 bjones86 commented Mar 5, 2020

https://jira.sakaiproject.org/browse/SAK-43381

Creating, editing and deleting Announcements via Admin Workspace (MOTD) appears to not work for a period of time until the cache is evicted.

This is caused by not building the channel ID for the MOTD (admin workspace) properly in AnnouncementObserver, so it effectively clears a non-existent cache in this context.

Copy link

@mpellicer mpellicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bjones86

@mpellicer mpellicer merged commit fb87313 into sakaiproject:master Mar 6, 2020
@bjones86 bjones86 deleted the SAK-43381 branch March 6, 2020 14:37
ern pushed a commit that referenced this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants