SAK-42376 - Content Picker accessibility - cannot tab into app store #7285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonespm
changed the title
|
https://jira.sakaiproject.org/browse/SAK-42376 I wondered why your fix took place in the CKEdtior... :) Please fix both. |
|
Yeah, it's because I was looking at another ticket first about how to setup the App Store, and noticed the problem with being able to tab into it. Though this is what this issue referenced. I'm sure it'll be easier to fix than CKEditor! I just will need a few days till I have time to look at it. |
|
@csev @fostersdesign any thoughts on this one? |
mpellicer
approved these changes
Oct 17, 2019
|
Makes sense to me @jonespm , thanks |
|
Nice job, @jonespm! That seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't entirely fix the issue mentioned on SAK-42376 as it fixes the content item picker tabbing into the app store, not Lessons. We can either add to this or create a second ticket.