Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-40004 - Javax dependencies updated #5851

Merged
merged 6 commits into from
Aug 14, 2018
Merged

SAK-40004 - Javax dependencies updated #5851

merged 6 commits into from
Aug 14, 2018

Conversation

deinok
Copy link
Contributor

@deinok deinok commented Aug 1, 2018

@ern As we talked

Raul Hidalgo Caballero added 6 commits August 1, 2018 10:00
* Add javax.mail

* changed to javax.mail

* deleted com.sun.mail

* moved to com.sun
* moved to fixed version

* javax.jcr is not required by anything, so deleting it
* Add javax.activation-api

* deploy

* samigo-services

* kernel-impl

* samigo-app

* import-util

* import-impl

* feedback

* content-handlers

* samigo-qti

* deleted dependency
* added javax.servlet.jsp-api

* help-tool

* postem-app

* sitestats-tool

* jsf-tool-sun

* tool

* podcasts-app

* calendar

* connector

* tool

* tool

* myfaces-tool

* tool

* tool

* ui

* jsf-widgets-sun

* jsf2-tool-sun

* syllabus-app

* business

* myfaces-widgets

* jsf2-widgets-sun

* messageforums-app

* jsf-widgets

* admin-perms-tool

* jsf2-widgets

* sections-app-util

* samigo-app

* deleted jsp-api
* added javax.servlet-api

* admin-tools

* del elfinder-sakai

* del kernel-util

* del cxf

* jsf-tool

* del tool

* jsf2-tool

* del impl

* tool

* Replaced all servelet-api for javax.servlet-api

* removed duplicated

* deleted duplicate

* del duplicates

* 4.0.1 cause some breaking changes

* jus add a coment of future tasks

* to v3.0.1

* Same for entitybroker rest

* downgrade to the last working master version

* render engine not upgraded for now
@ern
Copy link
Contributor

ern commented Aug 2, 2018

@deinok Thank you very much 🥇

Will you be adding additional commits to this (if so we'll add the work in progress label) or are you finished with this JIRA issue?

@deinok
Copy link
Contributor Author

deinok commented Aug 2, 2018

This PR is finished, the issue at jira not.

I think that the next step will be replace obsolete things of hibernate, next replace hibernate version and finally spring issues

@ern
Copy link
Contributor

ern commented Aug 2, 2018

Hibernate and Spring versions can be in their own JIRA issues and are not an issue with regards to JDK 9. Do you have any other JDK 9 tasks that should be added to this PR?

@deinok
Copy link
Contributor Author

deinok commented Aug 2, 2018

In this PR not.

Im using SAK-40004 as a meta issue, cause it is a really big task.
We can add a issue for hibernate and spring, and SAK-40004 depend on those.

But in fact, Hibernate and Spring are the biggest problem of JDK9, 10 and 11. (Due internal changes of JDK9). The problem is that we use a lot Hibernate and Spring and the upgrading will be hard.

@ern
Copy link
Contributor

ern commented Aug 7, 2018

Yes create separate JIRA issues and link those is fine.

@deinok
Copy link
Contributor Author

deinok commented Aug 7, 2018

Okey, then, this will be accepted?

@deinok
Copy link
Contributor Author

deinok commented Aug 11, 2018

@ern Can this be merged, I have a near due date to release a version of Sakai for my University compatible with newer versions of JDK and I prefer not make a fork of Sakai, becouse it will be complex merge that kind of changes.

@ern ern merged commit c27849c into sakaiproject:master Aug 14, 2018
@deinok deinok deleted the lib-union branch August 15, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants