SAK-40248: Begin the standardization of the toolbar for table controls (e.g. filtering and paging) across tools #5744
Conversation
|
I have attached screenshots to the JIRA ticket to illustrate some before and after shots of some of the pages improved by this change and to highlight the responsive design of the toolbar as well. |
…s (e.g. filtering and paging) across tools
| } | ||
| } | ||
|
|
||
| @media all and (max-width: 400px) |
There was a problem hiding this comment.
I would add another media variable on _defaults.scss just in case anyone else needs it.
There was a problem hiding this comment.
smallPhone or something like that
There was a problem hiding this comment.
This breakpoint is here specifically to allow the pager buttons to stack when there isn't enough room. 400px was chosen because of the size of the pager controls, so I don't know if it makes sense to base something general like "smallPhone" on this value.
| @@ -0,0 +1,23 @@ | |||
| // scripts for the #pagerPanel velocity macro (see VM_chef_library.vm in the velocity project) | |||
| // will use SPNR (spinner.js) if it is already loaded | |||
| var VM_PP = VM_PP || {}; | |||
There was a problem hiding this comment.
This is a codacy error. This is a common way to work on JS because you don't know if variable is set or not as @plukasew said. He totally has a point. This shouldn't be an error on Codacy for this kind of errors.
| { | ||
| if (typeof SPNR !== "undefined") // if SPNR is available, use it | ||
| { | ||
| SPNR.disableControlsAndSpin(selectElement, null); |
There was a problem hiding this comment.
Same as before, @plukasew did a great job, it's codacy error. In client JS files errors should be different than Java or Node files.
|
Great work, I think this will be a great improvement on tool navigation. |
|
If it's that the case please add that explanation as a comment in code so
it remains clear for everyone who see the code after us.
Thanks, great work indeed
El mié., 25 jul. 2018 14:42, plukasew <[email protected]> escribió:
… ***@***.**** commented on this pull request.
------------------------------
In library/src/morpheus-master/sass/modules/tool/_table.scss
<#5744 (comment)>:
> + padding-right: 0;
+ }
+
+ .sakai-table-pagerContainer
+ {
+ margin-left: 0;
+ padding-left: 0;
+ }
+
+ .sakai-table-searchFilter .sakai-table-searchFilter-searchField
+ {
+ width: 150px;
+ }
+ }
+
+ @media all and (max-width: 400px)
This breakpoint is here specifically to allow the pager buttons to stack
when there isn't enough room. 400px was chosen because of the size of the
pager controls, so I don't know if it makes sense to base something general
like "smallPhone" on this value.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5744 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADFpUnVYX1CT4M8Ezrgf7W2dAL1O_Jdiks5uKGe2gaJpZM4U7rnH>
.
|
|
Thanks, I've added a comment |
…s (e.g. filtering and paging) across tools (sakaiproject#5744)
…s (e.g. filtering and paging) across tools (sakaiproject#5744)
…s (e.g. filtering and paging) across tools (sakaiproject#5744)
https://jira.sakaiproject.org/browse/SAK-40248
As a small step of the standardization project known as SWITCH, standardize the view and paging controls found at the top of most tools. Start with a few tools, such as Assignments, Announcements, and Site Info.
Goals of this change:
Scope: