SAK-40128 Merge SU admin tools into one project. #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
axxter99
commented
Jun 13, 2018
axxter99
commented
- ./tool/tool-tool/su => ./admin-su
- pom.xlm: artifactI:admin-tool-su
1) ./tool/tool-tool/su => ./admin-su 2) pom.xlm: artifactI:admin-tool-su
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
|
@buckett ? |
buckett
reviewed
Jul 10, 2018
pom.xml
Outdated
| @@ -111,7 +111,7 @@ | |||
| <module>syllabus</module> | |||
| <module>taggable</module> | |||
| <module>textarea</module> | |||
| <module>tool</module> | |||
| <module>admin-su</module> | |||
There was a problem hiding this comment.
Could we move this line to keep them alphabetical?
pom.xml
Outdated
| @@ -194,7 +194,7 @@ | |||
| <module>syllabus</module> | |||
| <module>taggable</module> | |||
| <module>textarea</module> | |||
| <module>tool</module> | |||
| <module>admin-su</module> | |||
There was a problem hiding this comment.
Could we move this line to keep them alphabetical?
admin-su/pom.xml
Outdated
| <groupId>org.sakaiproject</groupId> | ||
| <artifactId>sakai-tool-tool-su</artifactId> | ||
| <groupId>org.sakaiproject.su</groupId> | ||
| <artifactId>admin-tool-su</artifactId> |
There was a problem hiding this comment.
It's generally better if the folder name matches the artifactId, I know Sakai is currently bad at this but would be nice if we could start the path to making it better.
https://blog.sonatype.com/2011/01/maven-tip-project-directories-and-artifact-ids/
|
Also currently has conflicts. |
|
@buckett, are you ok with the changes here? |
bjones86
pushed a commit
to bjones86/sakai
that referenced
this pull request
Aug 11, 2018
* SAK-40128 Merge SU admin tools into one project. 1) ./tool/tool-tool/su => ./admin-su 2) pom.xml: artifactId:admin-tool-su
bjones86
pushed a commit
to bjones86/sakai
that referenced
this pull request
Aug 21, 2018
* SAK-40128 Merge SU admin tools into one project. 1) ./tool/tool-tool/su => ./admin-su 2) pom.xml: artifactId:admin-tool-su
bjones86
pushed a commit
to bjones86/sakai
that referenced
this pull request
Aug 27, 2018
* SAK-40128 Merge SU admin tools into one project. 1) ./tool/tool-tool/su => ./admin-su 2) pom.xml: artifactId:admin-tool-su
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.