roster2 - Clean up instances of printStackTrace

roster2/src/java/org/sakaiproject/roster/api/RosterMemberComparator.java

@@ -37,21 +37,17 @@
 import java.util.Comparator;
 import java.text.Collator;
 
+import lombok.extern.slf4j.Slf4j;
 import lombok.RequiredArgsConstructor;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 /**
  * <code>Comparator</code> for <code>RosterMember</code>s.
  * 
  * @author [email protected]
  */
 @RequiredArgsConstructor
+@Slf4j
 public class RosterMemberComparator implements Comparator<RosterMember> {
-
-	private static final Logger log = LoggerFactory.getLogger(RosterMemberComparator.class);
-
 	private final boolean firstNameLastName;
 	private final Collator collator = Collator.getInstance();
 

roster2/src/java/org/sakaiproject/roster/impl/SakaiProxyImpl.java

@@ -38,10 +38,10 @@
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 
+import lombok.Setter;
+import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.lang.ArrayUtils;
-import org.sakaiproject.entity.api.ResourceProperties;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+
 import org.sakaiproject.api.privacy.PrivacyManager;
 import org.sakaiproject.authz.api.AuthzGroup;
 import org.sakaiproject.authz.api.FunctionManager;
@@ -55,6 +55,7 @@
 import org.sakaiproject.coursemanagement.api.EnrollmentSet;
 import org.sakaiproject.coursemanagement.api.Section;
 import org.sakaiproject.coursemanagement.api.exception.IdNotFoundException;
+import org.sakaiproject.entity.api.ResourceProperties;
 import org.sakaiproject.exception.IdUnusedException;
 import org.sakaiproject.event.api.Event;
 import org.sakaiproject.event.api.EventTrackingService;
@@ -82,19 +83,16 @@
 import org.sakaiproject.user.api.UserNotDefinedException;
 import org.sakaiproject.util.ResourceLoader;
 
-import lombok.Setter;
-
 /**
  * <code>SakaiProxy</code> acts as a proxy between Roster and Sakai components.
  * 
  * @author Daniel Robinson ([email protected])
  * @author Adrian Fish ([email protected])
  */
 @Setter
+@Slf4j
 public class SakaiProxyImpl implements SakaiProxy, Observer {
 
-	private static final Logger log = LoggerFactory.getLogger(SakaiProxyImpl.class);
-
 	private CourseManagementService courseManagementService;
 	private EventTrackingService eventTrackingService;
 	private FunctionManager functionManager;

roster2/src/java/org/sakaiproject/roster/tool/RosterTool.java

@@ -46,27 +46,25 @@
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-import org.sakaiproject.roster.api.SakaiProxy;
-import org.sakaiproject.util.ResourceLoader;
-
+import lombok.extern.slf4j.Slf4j;
 import org.springframework.context.ApplicationContext;
 import org.springframework.web.context.support.WebApplicationContextUtils;
 
+import org.sakaiproject.roster.api.SakaiProxy;
+import org.sakaiproject.util.ResourceLoader;
+
 /**
  * <code>RosterTool</code> performs basic checks and outputs a prebuilt startup
  * page.
  * 
  * @author Daniel Robinson ([email protected])
  * @author Adrian Fish ([email protected])
  */
+@Slf4j
 public class RosterTool extends HttpServlet {
 
 	private static final long serialVersionUID = 1L;
 
-	private static final Logger log = LoggerFactory.getLogger(RosterTool.class);
-
 	private SakaiProxy sakaiProxy;
 
     public void init(ServletConfig config) throws ServletException {

roster2/src/java/org/sakaiproject/roster/tool/entityprovider/RosterSiteEntityProvider.java

@@ -40,8 +40,9 @@
 import java.util.HashMap;
 import java.util.Map;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import lombok.Setter;
+import lombok.extern.slf4j.Slf4j;
+
 import org.sakaiproject.entitybroker.EntityReference;
 import org.sakaiproject.entitybroker.EntityView;
 import org.sakaiproject.entitybroker.entityprovider.annotations.EntityCustomAction;
@@ -59,8 +60,6 @@
 import org.sakaiproject.sitestats.api.SitePresenceTotal;
 import org.sakaiproject.user.api.User;
 
-import lombok.Setter;
-
 /**
  * <code>EntityProvider</code> to allow Roster to access site, membership, and
  * enrollment data for the current user. The provider respects Roster
@@ -69,12 +68,10 @@
  * 
  * @author [email protected]
  */
+@Slf4j
 public class RosterSiteEntityProvider extends AbstractEntityProvider implements
 		AutoRegisterEntityProvider, ActionsExecutable, Outputable {
 
-	@SuppressWarnings("unused")
-	private static final Logger log = LoggerFactory.getLogger(RosterSiteEntityProvider.class);
-
 	public final static String ENTITY_PREFIX		= "roster-membership";
 	public final static String DEFAULT_ID			= ":ID:";