SAK-33497 Remove conflicting commons-fileupload #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of commons-fileupload was explicitly set in the access-impl/impl/pom.xml file although would result in it getting used at compile time would result in the newer version getting used at runtime due to the fact that it’s a provided dependency so it uses the shared version from the shared class loader in tomcat. The used version is defined in master/pom.xml and is currently set at 1.3.3
ottenhoff
approved these changes
Oct 23, 2017
steveswinsburg
added a commit
to steveswinsburg/sakai
that referenced
this pull request
Oct 24, 2017
* 'master' of https://github.com/sakaiproject/sakai: SAK-33502 (sakaiproject#4909) SAK-33498 Removed unused commons-email dependency (sakaiproject#4904) SAK-33500 - Upgrade tika library to 1.16 (sakaiproject#4908) SAK-33497 Remove conflicting commons-fileupload (sakaiproject#4903) KNL-1555 (sakaiproject#4905) KNL-1556 (sakaiproject#4906) SAK-33499 (sakaiproject#4907) SAK-31960 (sakaiproject#4899) SAK-33486 (sakaiproject#4898) Assignments student submission view missing assignment attachments part 2 (sakaiproject#4897) SAK-33480 Assignments Student Submission Preview template (sakaiproject#4890) SAK-33479 Assignments student submission view missing assignment attachments (sakaiproject#4889) SAK-32346 (2) (sakaiproject#4893) SAK-32346 (sakaiproject#4891) SAK-33476 Assignments Student View Grade template fixes (sakaiproject#4888) SAK-33448 ensure column filter dropdown menus are not repositioned on scroll (sakaiproject#4885) SAK-33385 add ability to filter custom export by section/group (sakaiproject#4883) KNL-1541 - Missing fields initializer for change (sakaiproject#4886) AssignmentService API raw type (sakaiproject#4872)
ottenhoff
pushed a commit
that referenced
this pull request
Nov 26, 2017
The version of commons-fileupload was explicitly set in the access-impl/impl/pom.xml file although would result in it getting used at compile time would result in the newer version getting used at runtime due to the fact that it’s a provided dependency so it uses the shared version from the shared class loader in tomcat. The used version is defined in master/pom.xml and is currently set at 1.3.3 (cherry picked from commit 55760da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of commons-fileupload was explicitly set in the access-impl/impl/pom.xml file although would result in it getting used at compile time would result in the newer version getting used at runtime due to the fact that it’s a provided dependency so it uses the shared version from the shared class loader in tomcat.
The used version is defined in master/pom.xml and is currently set at 1.3.3