SAK-33326 Remove duplicate licenses. #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New standard license headers were introduced on these files but the old licenses were also left in place, this removes the old licenses.
ottenhoff
approved these changes
Sep 8, 2017
|
Thanks looks good. I'm not sure what we can do to better handle the files that you mentioned have multiple licenses. Either was can exclude these by the plugin or maybe get the plugin to recognize these as valid licenses. I didn't get around to looking into that configuration but think it should be done still. |
jonespm
approved these changes
Sep 8, 2017
|
I have a few directories set up to be ignored by the license plugin as they resulted in a lot of duplicates (I think JSF and delegated access). And the duplicates in delegated access with the menton of the "Trustees of Columbia" maybe should be retained? IANAL tho! ;) |
ern
pushed a commit
that referenced
this pull request
Sep 11, 2017
New standard license headers were introduced on these files but the old licenses were also left in place, this removes the old licenses. (cherry picked from commit 82488bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New standard license headers were introduced on these files but the old licenses were also left in place, this removes the old licenses.