Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-32675 - Update license plugin and license headers #4720

Merged
merged 2 commits into from
Aug 29, 2017

Conversation

jonespm
Copy link
Contributor

@jonespm jonespm commented Aug 22, 2017

No description provided.

@jonespm
Copy link
Contributor Author

jonespm commented Aug 22, 2017

I tried to tweak this plugin configuration the best I could. I'm not too sure if we can do any better automatically without changing the plugin?

This does not update any existing files (mostly it was changing the copyright year and the URL's) but for some reason a "few" files could not be detected correctly and have completely duplicate license headers here. I'd like to figure out a good idea for how to detect these and probably just remove the older one.

@buckett
Copy link
Member

buckett commented Aug 25, 2017

I see quite a few with duplicates (crude way to find them):

 egrep -rc 'Licensed under the Educational Community License,' . | grep ':2$' | wc -l

gives 192.

@jonespm
Copy link
Contributor Author

jonespm commented Aug 25, 2017

Yeah, do you have thoughts on an easy way of removing the duplicates? I thought about writing up a script but really this didn't seem like big enough of a deal to me. Ideally the license plugin would do it but again modifying it just for this didn't seem worth the effort. I'm 100% happy for someone else to do this better or find a better plugin/process.

@jonespm
Copy link
Contributor Author

jonespm commented Aug 25, 2017

Removing and cleaning the duplicates could also be a separate task. This is also ignoring a few directories that added a lot of duplicates (jsf/delegatedaccess) and some of the duplicates maybe should stay there or even have their dates updated, which this plugin would do if they header format was correct.

@jonespm jonespm merged commit 76df7af into sakaiproject:master Aug 29, 2017
@jonespm jonespm deleted the SAK-32675 branch January 6, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants