Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-49855 LTI13 let tool know what scopes the endpoint can handle #12441

Merged
merged 1 commit into from
Mar 20, 2024
Merged

SAK-49855 LTI13 let tool know what scopes the endpoint can handle #12441

merged 1 commit into from
Mar 20, 2024

Conversation

ottenhoff
Copy link
Contributor

@ottenhoff ottenhoff commented Mar 19, 2024 •
edited
Loading

@ottenhoff ottenhoff requested a review from csev March 19, 2024 18:22
@csev
Copy link
Contributor

csev commented Mar 19, 2024

@ottenhoff - this looks good - I edited the JIRA description to be more accurate. Here is the piece of the LTI spec that shows what is supposed to happen:

https://www.imsglobal.org/spec/lti-ags/v2p0#example-link-with-one-line-item-tool-has-all-permissions

@csev csev changed the title SAK-49855 LTI13 let tool know what endpoints we are capable of handling SAK-49855 LTI13 let tool know what scopes the endpoint can handle Mar 19, 2024
@ottenhoff ottenhoff merged commit 047c116 into sakaiproject:master Mar 20, 2024
4 checks passed
ern pushed a commit that referenced this pull request Apr 9, 2024
@ottenhoff @ern
SAK-49855 LTI13 let tool know what scopes the endpoint can handle (#1…
071454e 
…2441)

(cherry picked from commit 047c116)
ern pushed a commit that referenced this pull request Apr 9, 2024
@ottenhoff @ern
SAK-49855 LTI13 let tool know what scopes the endpoint can handle (#1…
f2810da 
…2441)

(cherry picked from commit 047c116)

 Conflicts:
	basiclti/basiclti-common/src/java/org/sakaiproject/basiclti/util/SakaiBLTIUtil.java
ern added a commit that referenced this pull request Jun 10, 2024
@ern
Revert "SAK-49855 LTI13 let tool know what scopes the endpoint can ha…
da65835 
…ndle (#12441)"

This reverts commit f2810da.
ern pushed a commit that referenced this pull request Jun 10, 2024
@ottenhoff @ern
SAK-49855 LTI13 let tool know what scopes the endpoint can handle (#1…
2d20d96 
…2441)

(cherry picked from commit 047c116)

 Conflicts:
	basiclti/basiclti-common/src/java/org/sakaiproject/basiclti/util/SakaiBLTIUtil.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csev csev csev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ottenhoff @csev