SAK-49730 Global updating maven plugins for validation issues #12370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonespm
commented
Feb 10, 2024
| @@ -14,10 +14,8 @@ | |||
| <packaging>war</packaging> | |||
|
|
|||
| <properties> | |||
| <frontend-maven-plugin.version>1.12.1</frontend-maven-plugin.version> | |||
| <frontend-maven-plugin.npmVersion>9.5.1</frontend-maven-plugin.npmVersion> | |||
There was a problem hiding this comment.
I'd think this npmVersion and nodeVersion should probably be defined in master for everything that uses this plugin? But it seems to work fine with these versions here using the updated frontend plugin. So maybe they're independent?
There was a problem hiding this comment.
They are independent, I'm happy to use the same version of the frontend-maven-plugin for everything, thanks Matt @jonespm !
ern
approved these changes
Feb 12, 2024
ern
changed the title
ern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built and started this up, everything seems like it's working as expected. The antrun-plugin looks like it's does the same thing as that other custom plugin we had.