SAK-49631 - "Exit Student View" not working on other tabs except "Overview" tab

[jonespm]

Some ideas for review.

I'm going to leave this as draft for now and am happy if someone does this differently or if this is almost good and I can fix it up.

Some things I didn't like:

I don't think these dropdowns should appear on the overview (iframe) divs but I don't see a better way to detect this other than $pageColumnLayout == 'col1'

I'm also not sure why some of these negative margins were in there and they made the link no longer appear.

I'm not sure if there's any other edge cases here or if there's a better place this dropdown could be placed.

Before switching

In view student mode

[jonespm]

I probably should look at that viewAsStudentLink variable in the backend to avoid the frontend check.

[kunaljaykam]

I don't think these dropdowns should appear on the overview (iframe) divs but I don't see a better way to detect this other than $pageColumnLayout == 'col1'

I'm also not sure why some of these negative margins were in there and they made the link no longer appear.

I'm not sure if there's any other edge cases here or if there's a better place this dropdown could be placed.

I said the same thing to myself when I did this PR for the updated portal. I hope someone will tell me if there's a better way to do it :). I like it. This is better than what I did. Thanks @jonespm

Do you mean, The Overview tool shouldn't have the option for role-swap?

I think the negative margins were there to align the dropdown. I wasn't happy with it either.

[jonespm]

Thanks for the comments, I added your change and also changed it to check for isHomePage rather than the double column which seems more straightforward since this is the page with 99% of the issue. I think it's looking pretty nice now. I checked it also on mobile view and seems pretty nice there too.

[kunaljaykam]

Thanks! with your fix. I think we can clear some CSS and JS as well. I have created a pull request on your branch for the same. Please take a look: jonespm#2

[kunaljaykam]

LGTM! Thanks @jonespm