SAK-49000 - Remove duplicate id in Site Manage Overview #11664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianfish
requested changes
Jun 12, 2023
There was a problem hiding this comment.
I'd prefer if we changed these to use lower case with hypens. move -> move-1. This mixture of capitalisation and underscores just doesn't look very coherent to me. We could, perhaps, make them more useful by calling them "lefttool-move-header" and righttool-move-header, something like that, so we have more idea straight away what they are.
|
@adrianfish - I agree that naming should be improved - yhere are three spots that need fixing - I will fix them. |
adrianfish
reviewed
Jun 12, 2023
site-manage/site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-siteInfo-manageOverview.vm
Outdated
Show resolved
Hide resolved
adrianfish
reviewed
Jun 12, 2023
site-manage/site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-siteInfo-manageOverview.vm
Outdated
Show resolved
Hide resolved
adrianfish
reviewed
Jun 12, 2023
site-manage/site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-siteInfo-manageOverview.vm
Outdated
Show resolved
Hide resolved
adrianfish
reviewed
Jun 12, 2023
site-manage/site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-siteInfo-manageOverview.vm
Outdated
Show resolved
Hide resolved
adrianfish
approved these changes
Jun 12, 2023
…_site-siteInfo-manageOverview.vm Co-authored-by: Adrian Fish <[email protected]>
…_site-siteInfo-manageOverview.vm Co-authored-by: Adrian Fish <[email protected]>
…_site-siteInfo-manageOverview.vm Co-authored-by: Adrian Fish <[email protected]>
…_site-siteInfo-manageOverview.vm Co-authored-by: Adrian Fish <[email protected]>
|
Thanks |
ern
pushed a commit
that referenced
this pull request
Jun 13, 2023
Co-authored-by: Adrian Fish <[email protected]> (cherry picked from commit 5d9bce7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.