SAK-48998 Footer build info is missing #11659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes [SAK-48998]. It looks like a previous commit pushed the antrun plugin back to 1.3. I tested some more and didn't see any issue upgrading everything up to 3.1.0. Everything is building and this fixes the issue.
|
I tested the ckeditor plugins and config builds as expected. I was getting an error with pack-bin but I'd never tested this before and looks to be an error when building in a container. This is nothing to do with the plugin and would need some separate fix. I tried to build out of a container and it worked fine. |
kunaljaykam
approved these changes
Jun 11, 2023
There was a problem hiding this comment.
I've tested it on different browsers and it works well. Thank you @jonespm for the quick fix.
ern
pushed a commit
that referenced
this pull request
Jun 13, 2023
(cherry picked from commit 8b5931c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes SAK-48998. It looks like a previous commit pushed the antrun plugin back to 1.3.
I tested some more and didn't see any issue upgrading everything up to 3.1.0. Everything is building and this fixes the issue.