SAK-45911 - Profile | Pronunciation recording clears other fields' data #11511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianfish
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required a lot of research and trial/error but the end result actually seemed came out to be pretty simple.
It actually comes out to be about 300KB/second rather than 1MB/second so maybe the default should be 1/2 or even 1/3 the duration. I doubt anyone is going to increase this much beyond the max and maybe we don't even need another setting. I was thinking of just setting it to
getNamePronunciationDuration()/2MB.What do you think?
I reworked it from the original commit and removed the specific configuration and just set it to be 500KB/sec.