Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-46617 Tests & Quizzes: Exceptions have restrictions not present for non-excepted students #10089

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

ropemar
Copy link
Contributor

@ropemar ropemar commented Dec 13, 2021

https://sakaiproject.atlassian.net/browse/SAK-46617

I've deleted the validation for the due date being greater or equal to the current date and all properties refered to this restriction.

@ropemar ropemar marked this pull request as ready for review January 20, 2022 16:36
@mpellicer
Copy link

Please rebase it @ropemar

@ottenhoff
Copy link
Contributor

I'd like to hear from @bjones86 on this

@bjones86
Copy link
Member

I'm in favour of removing this outright prevention. However, I think it would be better to provide a warning in this scenario, just to avoid any unintentional mistakes.

Copy link
Member

@bjones86 bjones86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to see this implemented as a warning. The warning should be presented if the due date is in the past, but should be allowed if the instructor wishes to continue.

@ropemar
Copy link
Contributor Author

ropemar commented Feb 3, 2022

Changed the PR to convert this validation to a warning instead of a mandatory requisite. In order to make this possible, I had to implement a separate visualization of warnings and error messages, since the settings form only showed error message boxes.

@bjones86
Copy link
Member

bjones86 commented Feb 3, 2022

Thanks, @ropemar. Can you add a screenshot of this new functionality to the JIRA ticket?

@ropemar
Copy link
Contributor Author

ropemar commented Feb 3, 2022

Yes, of course. You have it right now on the JIRA.

Copy link
Member

@bjones86 bjones86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this as a warning! I just have some very minor comments.

…or non-excepted students

SAK-46617 Tests & Quizzes: Exceptions have restrictions not present for non-excepted students
@bjones86
Copy link
Member

bjones86 commented Feb 3, 2022

Thanks, @ropemar! I'd just like to wait for @fostersdesign to review the message language.

@fostersdesign
Copy link
Contributor

The wording looks okay to me.

The Teaching & Learning group and the Sakai UX group were just talking last week about this convention of warning people of dates in the past and having them click the button again to proceed in Assignments. We felt it was a clunky way to confirm a warning and so we proposed some changes on SAK-46356. That shouldn't block this work from getting in. In the future, the replacement for this convention should probably be standardized across tools though.

@bjones86 bjones86 merged commit 78d66ca into sakaiproject:master Feb 7, 2022
ern pushed a commit that referenced this pull request Feb 14, 2022
…or non-excepted students (#10089)

(cherry picked from commit 78d66ca)
ern pushed a commit that referenced this pull request Mar 28, 2022
…or non-excepted students (#10089)

(cherry picked from commit 78d66ca)

 Conflicts:
	samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/AssessmentSettingsMessages.properties
	samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/AssessmentSettingsMessages_es.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants