-
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-46617 Tests & Quizzes: Exceptions have restrictions not present for non-excepted students #10089
Conversation
Please rebase it @ropemar |
I'd like to hear from @bjones86 on this |
I'm in favour of removing this outright prevention. However, I think it would be better to provide a warning in this scenario, just to avoid any unintentional mistakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to see this implemented as a warning. The warning should be presented if the due date is in the past, but should be allowed if the instructor wishes to continue.
Changed the PR to convert this validation to a warning instead of a mandatory requisite. In order to make this possible, I had to implement a separate visualization of warnings and error messages, since the settings form only showed error message boxes. |
Thanks, @ropemar. Can you add a screenshot of this new functionality to the JIRA ticket? |
Yes, of course. You have it right now on the JIRA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing this as a warning! I just have some very minor comments.
...igo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/AssessmentSettingsBean.java
Outdated
Show resolved
Hide resolved
...igo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/AssessmentSettingsBean.java
Outdated
Show resolved
Hide resolved
...igo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/AssessmentSettingsBean.java
Outdated
Show resolved
Hide resolved
...igo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/AssessmentSettingsBean.java
Outdated
Show resolved
Hide resolved
...o-app/src/java/org/sakaiproject/tool/assessment/bundle/AssessmentSettingsMessages.properties
Outdated
Show resolved
Hide resolved
…or non-excepted students SAK-46617 Tests & Quizzes: Exceptions have restrictions not present for non-excepted students
Thanks, @ropemar! I'd just like to wait for @fostersdesign to review the message language. |
The wording looks okay to me. The Teaching & Learning group and the Sakai UX group were just talking last week about this convention of warning people of dates in the past and having them click the button again to proceed in Assignments. We felt it was a clunky way to confirm a warning and so we proposed some changes on SAK-46356. That shouldn't block this work from getting in. In the future, the replacement for this convention should probably be standardized across tools though. |
https://sakaiproject.atlassian.net/browse/SAK-46617
I've deleted the validation for the due date being greater or equal to the current date and all properties refered to this restriction.