Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2622 drawer-end makes horizontal scrollbar permanently visible #2630

Conversation

binjuhor
Copy link
Contributor

@binjuhor binjuhor commented Dec 8, 2023

  • Updated src/components/styled/drawer.css to add overflow-hidden

…visible

+ Updated src/components/styled/drawer.css to add overflow-hidden
@saadeghi saadeghi self-assigned this Dec 8, 2023
Copy link
Owner

@saadeghi saadeghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem? can you give a screenshot?

src/components/styled/drawer.css Outdated Show resolved Hide resolved
@lucasrivoiro
Copy link

I have same issue here, but applying overflow-x-hidden to drawer-side create another issue for me. Applying overflow-x-hidden turns the entire window vertically scrollable, but horizontally fix the issue.

@binjuhor
Copy link
Contributor Author

@lucasrivoiro Can you share me the screenshot? I think the window vertical should scrollable because the content can be so long like this

Screen.Recording.2023-12-14.at.09.20.57.mov

…g-drawer-end-makes-horizontal-scrollbar-permanently-visible
@LanceMoe
Copy link

At Windows, Or set the scroll bar to always show in macOS, the Drawer will show a scroll bar.
Before version 4.4.14, it worked well.
image

@brendoarrudaa
Copy link

Any chance of error being adjusted? I'm in a project that after upgrading from version 3 to 4 broke the entire drawer end of the page

@brendoarrudaa
Copy link

Any way to get past this bug? it is breaking my entire application

image

@cloudhoy
Copy link

cloudhoy commented Jan 23, 2024

@brendoarrudaa for now, you can fix this by adding overflow-x-hidden to element with the drawer-side class:

<div class="drawer-side overflow-x-hidden">
  {/* Sidebar content here */}
</div>

@binjuhor
Copy link
Contributor Author

@cloudhoy Yeah that also my solution, but I don't know why this PR has not merged yet.

@brendoarrudaa
Copy link

@cloudhoy I share the same feeling, it just needs to be approved to resolve the bugs,
@saadeghi Any chance of being approved?

@saadeghi saadeghi merged commit a795f48 into saadeghi:master Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants