Upgrade tar dependency to v7.x #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropping support for node 6 and 8 (as tar v6 drops that support as well) Addresses CVE-2024-28863
I'm not a fan of `^` as it can introduce breaking changes Co-authored-by: Ryan Pendergast <[email protected]>
|
Thanks for your fast answer. Commited your suggested change with your comment! Looking forward to merge and release! |
rynop
approved these changes
Sep 4, 2024
|
Version thanks! |
|
Thank you for the fast release <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping support for node 6 and 8 (as tar v6 drops that support as well).
Addresses CVE-2024-28863
I did not notice any breaking changes in the api of tar (as it still works when tested it using our project).
The only breaking change library side is that you can not use it in node 6 and 8 anymore (but I dont think anybody is on that version anymore).
I've verified it works by running following commands:
node examples/simple.js(I've added a simple setTimeout function which waits 2min before shutting it down, see here)aws dynamodb list-tables --endpoint-url http://localhost:8000